Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py open sci review #61

Merged
merged 35 commits into from
Jul 2, 2024
Merged

Py open sci review #61

merged 35 commits into from
Jul 2, 2024

Conversation

jbousquin
Copy link
Collaborator

suggestion (domain.py): replace x in list(set(pandas_series)) pattern w/ .unique method

jbousquin and others added 30 commits April 1, 2024 11:08
Fix typo (readme.md): l7 on package name
Fix typo (readme.md): double spaces
Edit (general): new line at each full stop in a markdown paragraph.
fix typo (contributing.rst): double spaces
Edit (general): adding a new line at each full stop in a rst paragraph.
Edit (general): add a new line at each full stop in a markdown or rst paragraph.
Edit (general): add a new line at each full stop in a markdown or rst paragraph.
… done in the try/except was a bit proactive and gets problematic with keeping the functions in a linear workflow.
… meant to get the updated list, but will need to keep an eye out for additions for the example in docs like this. Especailly right now as there may be updates with WQX 2.0 -> 3.0.
* Update README.md

Fix typo (readme.md): l7 on package name

* Update README.md

Fix typo (readme.md): double spaces

* Update README.md

Edit (general): new line at each full stop in a markdown paragraph.

* Update contributing.rst

fix typo (contributing.rst): double spaces

* Update contributing.rst

Edit (general): adding a new line at each full stop in a rst paragraph.

* Update example workflow.rst

Edit (general): add a new line at each full stop in a markdown or rst paragraph.

* Update index.rst

Edit (general): add a new line at each full stop in a markdown or rst paragraph.

* wet_dry_drop() has become outside the normal workflow, what was being done in the try/except was a bit proactive and gets problematic with keeping the functions in a linear workflow.

* from harmonize -> clean: df_checks(). add_qa_flag()

* convert_unit_series() moved harmonize -> convert

* Import specific functions instead of module

* Fix docs examples

* Module needs to be imported for example

* 'Filter/sieve residue' & 'Yield' now included in this domain. This is meant to get the updated list, but will need to keep an eye out for additions for the example in docs like this. Especailly right now as there may be updates with WQX 2.0 -> 3.0.
Update branch to main
…_col) -> unit_basis_dict[out_col], basis_conversion, stp_dict).
@jbousquin jbousquin merged commit 6b1cd87 into main Jul 2, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant